summaryrefslogtreecommitdiffstats
path: root/REPORTING-BUGS
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2009-09-22 14:44:11 +0200
committerIngo Molnar <mingo@elte.hu>2009-09-22 14:05:48 +0200
commitedaac8e3167501cda336231d00611bf59c164346 (patch)
tree5ebf22336dccef4fcd601e0a6a2d13ea347ec568 /REPORTING-BUGS
parentratelimit: Use per ratelimit context locking (diff)
downloadlinux-edaac8e3167501cda336231d00611bf59c164346.tar.xz
linux-edaac8e3167501cda336231d00611bf59c164346.zip
ratelimit: Fix/allow use in atomic contexts
I'd like to use printk_ratelimit() in NMI context, but it's not robust right now due to spinlock usage in lib/ratelimit.c. If an NMI is unlucky enough to hit just that spot we might lock up trying to take the spinlock again. Fix that by using a trylock variant. If we contend on that lock we can genuinely skip the message because the state is just being accessed by another CPU (or by this CPU). ( We could use atomics for the suppressed messages field, but i doubt it matters in practice and it makes the code heavier. ) Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: David S. Miller <davem@davemloft.net> LKML-Reference: <new-submission> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'REPORTING-BUGS')
0 files changed, 0 insertions, 0 deletions