diff options
| author | Eric Dumazet <edumazet@google.com> | 2017-11-02 20:30:25 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-11-03 06:29:01 +0100 |
| commit | 3b11775033dc87c3d161996c54507b15ba26414a (patch) | |
| tree | 01e52ff98514d77a36116f02f3745b1bce20d519 /arch/arm/mach-shmobile/r8a7790.h | |
| parent | fib: fib_dump_info can no longer use __in_dev_get_rtnl (diff) | |
| download | linux-3b11775033dc87c3d161996c54507b15ba26414a.tar.xz linux-3b11775033dc87c3d161996c54507b15ba26414a.zip | |
tcp: do not mangle skb->cb[] in tcp_make_synack()
Christoph Paasch sent a patch to address the following issue :
tcp_make_synack() is leaving some TCP private info in skb->cb[],
then send the packet by other means than tcp_transmit_skb()
tcp_transmit_skb() makes sure to clear skb->cb[] to not confuse
IPv4/IPV6 stacks, but we have no such cleanup for SYNACK.
tcp_make_synack() should not use tcp_init_nondata_skb() :
tcp_init_nondata_skb() really should be limited to skbs put in write/rtx
queues (the ones that are only sent via tcp_transmit_skb())
This patch fixes the issue and should even save few cpu cycles ;)
Fixes: 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Christoph Paasch <cpaasch@apple.com>
Reviewed-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/arm/mach-shmobile/r8a7790.h')
0 files changed, 0 insertions, 0 deletions