summaryrefslogtreecommitdiffstats
path: root/arch/mips/generic/Kconfig
diff options
context:
space:
mode:
authorPaul Cercueil <paul@crapouillou.net>2020-09-06 21:29:24 +0200
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>2020-09-18 16:27:32 +0200
commit5f5ed0ebcf84c7479c93a28c5c0e1b0b6926883b (patch)
tree879402e638c52de12adb0fb2a18b3b63ba5df04b /arch/mips/generic/Kconfig
parentMIPS: cpu-probe: Mark XBurst CPU as having vtagged caches (diff)
downloadlinux-5f5ed0ebcf84c7479c93a28c5c0e1b0b6926883b.tar.xz
linux-5f5ed0ebcf84c7479c93a28c5c0e1b0b6926883b.zip
MIPS: cpu-probe: ingenic: Fix broken BUG_ON
The previous code was doing: BUG_ON(!__builtin_constant_p(cpu_has_counter) || cpu_has_counter); This only worked as the "cpu_has_counter" macro was overridden in <cpu-feature-overrides.h>. The default "cpu_has_counter" macro is non-constant, which triggered the BUG_ON() independently of the value returned by the macro. What we want to check here, is that *if* the macro was overridden to a compile-time constant, then must be defined to zero, otherwise it's a bug. So the correct check is: BUG_ON(__builtin_constant_p(cpu_has_counter) && cpu_has_counter); Signed-off-by: Paul Cercueil <paul@crapouillou.net> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Diffstat (limited to 'arch/mips/generic/Kconfig')
0 files changed, 0 insertions, 0 deletions