summaryrefslogtreecommitdiffstats
path: root/arch/mips/sni/rm200.c
diff options
context:
space:
mode:
authorafzal mohammed <afzal.mohd.ma@gmail.com>2020-03-14 09:13:12 +0100
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>2020-03-16 16:04:49 +0100
commit49e6e07e3c806c311e07da14a6d6e406ac9e719c (patch)
tree459d9fcb836127080e623345e253d83e7ba72de9 /arch/mips/sni/rm200.c
parentMIPS: Replace setup_irq() by request_irq() (diff)
downloadlinux-49e6e07e3c806c311e07da14a6d6e406ac9e719c.tar.xz
linux-49e6e07e3c806c311e07da14a6d6e406ac9e719c.zip
MIPS: pass non-NULL dev_id on shared request_irq()
Recently all usages of setup_irq() was replaced by request_irq(). request_irq() does a few sanity checks that were not done in setup_irq(), if they fail irq registration will fail. One of the check is to ensure that non-NULL dev_id is passed in the case of shared irq. This caused malta on qemu to hang. Fix it by passing handler as dev_id to all request_irq()'s that are shared. For sni, instead of passing non-NULL dev_id, remove shared irq flags. Fixes: ac8fd122e070 ("MIPS: Replace setup_irq() by request_irq()") Reported-by: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com> Tested-by: Guenter Roeck <linux@roeck-us.net> Tested-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Diffstat (limited to 'arch/mips/sni/rm200.c')
-rw-r--r--arch/mips/sni/rm200.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/mips/sni/rm200.c b/arch/mips/sni/rm200.c
index ba1f2fc6a43e..d84744ca871d 100644
--- a/arch/mips/sni/rm200.c
+++ b/arch/mips/sni/rm200.c
@@ -473,10 +473,10 @@ void __init sni_rm200_irq_init(void)
sni_hwint = sni_rm200_hwint;
change_c0_status(ST0_IM, IE_IRQ0);
if (request_irq(SNI_RM200_INT_START + 0, sni_rm200_i8259A_irq_handler,
- IRQF_SHARED, "onboard ISA", NULL))
+ 0, "onboard ISA", NULL))
pr_err("Failed to register onboard ISA interrupt\n");
- if (request_irq(SNI_RM200_INT_START + 1, sni_isa_irq_handler,
- IRQF_SHARED, "ISA", NULL))
+ if (request_irq(SNI_RM200_INT_START + 1, sni_isa_irq_handler, 0, "ISA",
+ NULL))
pr_err("Failed to register ISA interrupt\n");
}