diff options
| author | Guillaume Knispel <gknispel@proformatique.com> | 2008-12-09 15:28:34 +0100 |
|---|---|---|
| committer | Kumar Gala <galak@kernel.crashing.org> | 2008-12-17 17:06:14 +0100 |
| commit | af4d3643864ee5fcba0c97d77a424fa0b0346f8e (patch) | |
| tree | ed8af088c50a41c011abde88bf970a4faa28b1dc /arch/powerpc/lib/rheap.c | |
| parent | powerpc/fsl-booke: Fix the miss interrupt restore (diff) | |
| download | linux-af4d3643864ee5fcba0c97d77a424fa0b0346f8e.tar.xz linux-af4d3643864ee5fcba0c97d77a424fa0b0346f8e.zip | |
powerpc: Fix corruption error in rh_alloc_fixed()
There is an error in rh_alloc_fixed() of the Remote Heap code:
If there is at least one free block blk won't be NULL at the end of the
search loop, so -ENOMEM won't be returned and the else branch of
"if (bs == s || be == e)" will be taken, corrupting the management
structures.
Signed-off-by: Guillaume Knispel <gknispel@proformatique.com>
Acked-by: Timur Tabi <timur@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/lib/rheap.c')
| -rw-r--r-- | arch/powerpc/lib/rheap.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/lib/rheap.c b/arch/powerpc/lib/rheap.c index 29b2941cada0..45907c1dae66 100644 --- a/arch/powerpc/lib/rheap.c +++ b/arch/powerpc/lib/rheap.c @@ -556,6 +556,7 @@ unsigned long rh_alloc_fixed(rh_info_t * info, unsigned long start, int size, co be = blk->start + blk->size; if (s >= bs && e <= be) break; + blk = NULL; } if (blk == NULL) |