diff options
| author | Randy Dunlap <rdunlap@infradead.org> | 2022-05-02 21:29:41 +0200 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2022-05-04 11:37:47 +0200 |
| commit | 5bb99fd4090fe1acfdb90a97993fcda7f8f5a3d6 (patch) | |
| tree | e0541e2750f92988facfa5ceaf31059428559ff0 /arch/powerpc/platforms/4xx | |
| parent | powerpc/idle: Fix return value of __setup() handler (diff) | |
| download | linux-5bb99fd4090fe1acfdb90a97993fcda7f8f5a3d6.tar.xz linux-5bb99fd4090fe1acfdb90a97993fcda7f8f5a3d6.zip | |
powerpc/4xx/cpm: Fix return value of __setup() handler
__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings.
Also, error return codes don't mean anything to obsolete_checksetup() --
only non-zero (usually 1) or zero. So return 1 from cpm_powersave_off().
Fixes: d164f6d4f910 ("powerpc/4xx: Add suspend and idle support")
Reported-by: Igor Zhbanov <izh1979@gmail.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220502192941.20955-1-rdunlap@infradead.org
Diffstat (limited to 'arch/powerpc/platforms/4xx')
| -rw-r--r-- | arch/powerpc/platforms/4xx/cpm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/4xx/cpm.c b/arch/powerpc/platforms/4xx/cpm.c index 2571841625a2..1d3bc35ee1a7 100644 --- a/arch/powerpc/platforms/4xx/cpm.c +++ b/arch/powerpc/platforms/4xx/cpm.c @@ -327,6 +327,6 @@ late_initcall(cpm_init); static int __init cpm_powersave_off(char *arg) { cpm.powersave_off = 1; - return 0; + return 1; } __setup("powersave=off", cpm_powersave_off); |