diff options
author | Salman Qazi <sqazi@google.com> | 2009-02-24 03:03:04 +0100 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-02-24 17:16:36 +0100 |
commit | 30d697fa3a25fed809a873b17531a00282dc1234 (patch) | |
tree | bc17d39779914b4dcf7a7d7b9e08d8b020cbf0b6 /arch/x86/kernel/head_64.S | |
parent | x86: compressed head_32 - use ENTRY,ENDPROC macros (diff) | |
download | linux-30d697fa3a25fed809a873b17531a00282dc1234.tar.xz linux-30d697fa3a25fed809a873b17531a00282dc1234.zip |
x86: fix performance regression in write() syscall
While the introduction of __copy_from_user_nocache (see commit:
0812a579c92fefa57506821fa08e90f47cb6dbdd) may have been an improvement
for sufficiently large writes, there is evidence to show that it is
deterimental for small writes. Unixbench's fstime test gives the
following results for 256 byte writes with MAX_BLOCK of 2000:
2.6.29-rc6 ( 5 samples, each in KB/sec ):
283750, 295200, 294500, 293000, 293300
2.6.29-rc6 + this patch (5 samples, each in KB/sec):
313050, 3106750, 293350, 306300, 307900
2.6.18
395700, 342000, 399100, 366050, 359850
See w_test() in src/fstime.c in unixbench version 4.1.0. Basically, the above test
consists of counting how much we can write in this manner:
alarm(10);
while (!sigalarm) {
for (f_blocks = 0; f_blocks < 2000; ++f_blocks) {
write(f, buf, 256);
}
lseek(f, 0L, 0);
}
Note, there are other components to the write syscall regression
that are not addressed here.
Signed-off-by: Salman Qazi <sqazi@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/head_64.S')
0 files changed, 0 insertions, 0 deletions