diff options
| author | Wen Yang <wen.yang99@zte.com.cn> | 2019-03-01 09:56:46 +0100 |
|---|---|---|
| committer | Shawn Guo <shawnguo@kernel.org> | 2019-03-19 09:48:00 +0100 |
| commit | 0c17e83fe423467e3ccf0a02f99bd050a73bbeb4 (patch) | |
| tree | 43d7aa5d83486fe0237dd35aa1e4ca5f55476477 /arch | |
| parent | ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port (diff) | |
| download | linux-0c17e83fe423467e3ccf0a02f99bd050a73bbeb4.tar.xz linux-0c17e83fe423467e3ccf0a02f99bd050a73bbeb4.zip | |
ARM: imx51: fix a leaked reference by adding missing of_node_put
The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.
Detected by coccinelle with the following warnings:
./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/arm/mach-imx/mach-imx51.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/arm/mach-imx/mach-imx51.c b/arch/arm/mach-imx/mach-imx51.c index c7169c2f94c4..08c7892866c2 100644 --- a/arch/arm/mach-imx/mach-imx51.c +++ b/arch/arm/mach-imx/mach-imx51.c @@ -59,6 +59,7 @@ static void __init imx51_m4if_setup(void) return; m4if_base = of_iomap(np, 0); + of_node_put(np); if (!m4if_base) { pr_err("Unable to map M4IF registers\n"); return; |