diff options
| author | Keith Busch <kbusch@kernel.org> | 2020-08-06 23:58:37 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-08-22 01:09:22 +0200 |
| commit | e4b469c66f3cbb81c2e94d31123d7bcdf3c1dabd (patch) | |
| tree | 24f135d23704e2ec34c87f0ee6bf976edc2acd2f /block/blk-merge.c | |
| parent | blk-mq: insert request not through ->queue_rq into sw/scheduler queue (diff) | |
| download | linux-e4b469c66f3cbb81c2e94d31123d7bcdf3c1dabd.tar.xz linux-e4b469c66f3cbb81c2e94d31123d7bcdf3c1dabd.zip | |
block: fix get_max_io_size()
A previous commit aligning splits to physical block sizes inadvertently
modified one return case such that that it now returns 0 length splits
when the number of sectors doesn't exceed the physical offset. This
later hits a BUG in bio_split(). Restore the previous working behavior.
Fixes: 9cc5169cd478b ("block: Improve physical block alignment of split bios")
Reported-by: Eric Deal <eric.deal@wdc.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-merge.c')
| -rw-r--r-- | block/blk-merge.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-merge.c b/block/blk-merge.c index 7af1f3668a91..f685d633bcc9 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -154,7 +154,7 @@ static inline unsigned get_max_io_size(struct request_queue *q, if (max_sectors > start_offset) return max_sectors - start_offset; - return sectors & (lbs - 1); + return sectors & ~(lbs - 1); } static inline unsigned get_max_segment_size(const struct request_queue *q, |