diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2018-07-11 17:21:05 +0200 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2018-07-11 19:45:28 +0200 |
| commit | 23ebda2fc715534d383d59ae6740d4e3ebd43798 (patch) | |
| tree | a94766bcc0e926fffa87fa941adb25787e1c923f /drivers/ata/pata_via.c | |
| parent | ata: ahci_platform: allow disabling of hotplug to save power (diff) | |
| download | linux-23ebda2fc715534d383d59ae6740d4e3ebd43798.tar.xz linux-23ebda2fc715534d383d59ae6740d4e3ebd43798.zip | |
libata: remove ata_sff_data_xfer_noirq()
ata_sff_data_xfer_noirq() is invoked via the ->sff_data_xfer hook. The
latter is invoked by ata_pio_sector(), atapi_send_cdb() and
__atapi_pio_bytes() which in turn is invoked by ata_sff_hsm_move().
The latter function requires that the "ap->lock" lock is held which
needs to be taken with disabled interrupts.
There is no need have to have ata_sff_data_xfer_noirq() which invokes
ata_sff_data_xfer32() with disabled interrupts because at this point the
interrupts are already disabled.
Remove the function and its references to it and replace all callers
with ata_sff_data_xfer32().
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata/pata_via.c')
| -rw-r--r-- | drivers/ata/pata_via.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/pata_via.c b/drivers/ata/pata_via.c index 1ca6bcab369f..fd19f1ce83aa 100644 --- a/drivers/ata/pata_via.c +++ b/drivers/ata/pata_via.c @@ -471,7 +471,7 @@ static struct ata_port_operations via_port_ops = { static struct ata_port_operations via_port_ops_noirq = { .inherits = &via_port_ops, - .sff_data_xfer = ata_sff_data_xfer_noirq, + .sff_data_xfer = ata_sff_data_xfer32, }; /** |