diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-02-14 17:28:29 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2023-03-14 10:06:41 +0100 |
| commit | 0e44db95eecb30aade0cac6cb8450e8bceeff4d2 (patch) | |
| tree | cc19eae2a95af2a7afe0a93aff882f74412b0351 /drivers/char | |
| parent | hwrng: xgene - Simplify using devm_clk_get_optional_enabled() (diff) | |
| download | linux-0e44db95eecb30aade0cac6cb8450e8bceeff4d2.tar.xz linux-0e44db95eecb30aade0cac6cb8450e8bceeff4d2.zip | |
hwrng: xgene - Improve error reporting for problems during .remove()
Returning an error value in a platform driver's remove callback results in
a generic error message being emitted by the driver core, but otherwise it
doesn't make a difference. The device goes away anyhow.
As the driver already emits a better error message than the core, suppress
the generic error message by returning zero unconditionally.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/hw_random/xgene-rng.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c index 31662614a48f..c67d3185b5b6 100644 --- a/drivers/char/hw_random/xgene-rng.c +++ b/drivers/char/hw_random/xgene-rng.c @@ -366,7 +366,7 @@ static int xgene_rng_remove(struct platform_device *pdev) if (rc) dev_err(&pdev->dev, "RNG init wakeup failed error %d\n", rc); - return rc; + return 0; } static const struct of_device_id xgene_rng_of_match[] = { |