diff options
author | Leonard Crestez <leonard.crestez@nxp.com> | 2019-11-21 14:52:17 +0100 |
---|---|---|
committer | Shawn Guo <shawnguo@kernel.org> | 2019-12-09 03:36:34 +0100 |
commit | 2ef139393fdcb7e8016aab9f649696c06d73deb1 (patch) | |
tree | 54e72a13e59d8a7854bbb99e10e8c024adb66c44 /drivers/clk/imx | |
parent | clk: imx7ulp: Fix watchdog2 clock name typo (diff) | |
download | linux-2ef139393fdcb7e8016aab9f649696c06d73deb1.tar.xz linux-2ef139393fdcb7e8016aab9f649696c06d73deb1.zip |
clk: imx8m: Suppress bind attrs
The clock drivers on imx8m series are registered as platform devices and
this opens the possibility of reloading the driver at runtime.
This doesn't actually work: clocks are never removed and attempting to
bind again results in registration errors and a crash. Almost all
devices depend on clocks anyway so rebinding is unlikely to ever be
useful
Fix this by explicitly suppressing bind attrs like several other
clock drivers.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Diffstat (limited to 'drivers/clk/imx')
-rw-r--r-- | drivers/clk/imx/clk-imx8mm.c | 5 | ||||
-rw-r--r-- | drivers/clk/imx/clk-imx8mn.c | 5 | ||||
-rw-r--r-- | drivers/clk/imx/clk-imx8mq.c | 5 |
3 files changed, 15 insertions, 0 deletions
diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c index 9246e89bb5fd..d5e767e399db 100644 --- a/drivers/clk/imx/clk-imx8mm.c +++ b/drivers/clk/imx/clk-imx8mm.c @@ -621,6 +621,11 @@ static struct platform_driver imx8mm_clk_driver = { .probe = imx8mm_clocks_probe, .driver = { .name = "imx8mm-ccm", + /* + * Disable bind attributes: clocks are not removed and + * reloading the driver will crash or break devices. + */ + .suppress_bind_attrs = true, .of_match_table = of_match_ptr(imx8mm_clk_of_match), }, }; diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c index 4749beab9fc8..b0e07784defb 100644 --- a/drivers/clk/imx/clk-imx8mn.c +++ b/drivers/clk/imx/clk-imx8mn.c @@ -578,6 +578,11 @@ static struct platform_driver imx8mn_clk_driver = { .probe = imx8mn_clocks_probe, .driver = { .name = "imx8mn-ccm", + /* + * Disable bind attributes: clocks are not removed and + * reloading the driver will crash or break devices. + */ + .suppress_bind_attrs = true, .of_match_table = of_match_ptr(imx8mn_clk_of_match), }, }; diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c index c8ab86fcba7c..14a1483b7d9f 100644 --- a/drivers/clk/imx/clk-imx8mq.c +++ b/drivers/clk/imx/clk-imx8mq.c @@ -613,6 +613,11 @@ static struct platform_driver imx8mq_clk_driver = { .probe = imx8mq_clocks_probe, .driver = { .name = "imx8mq-ccm", + /* + * Disable bind attributes: clocks are not removed and + * reloading the driver will crash or break devices. + */ + .suppress_bind_attrs = true, .of_match_table = of_match_ptr(imx8mq_clk_of_match), }, }; |