diff options
| author | George Cherian <george.cherian@cavium.com> | 2017-02-14 10:23:17 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2017-02-15 06:23:50 +0100 |
| commit | 6ecb7d62bf8ef34325fa55e8cf167610ed7abe83 (patch) | |
| tree | ebf1824341ff1e9660c89c80278b294297038dde /drivers/crypto | |
| parent | crypto: doc - fix typo (diff) | |
| download | linux-6ecb7d62bf8ef34325fa55e8cf167610ed7abe83.tar.xz linux-6ecb7d62bf8ef34325fa55e8cf167610ed7abe83.zip | |
crypto: cavium - cpt_bind_vq_to_grp could return an error code
cpt_bind_vq_to_grp() could return an error code. However, it currently
returns a u8. This produce the static checker warning.
drivers/crypto/cavium/cpt/cptpf_mbox.c:70 cpt_bind_vq_to_grp() warn: signedness bug returning '(-22)'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: George Cherian <george.cherian@cavium.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/cavium/cpt/cptpf_mbox.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/crypto/cavium/cpt/cptpf_mbox.c b/drivers/crypto/cavium/cpt/cptpf_mbox.c index 5818b415e814..20f2c6ee46a5 100644 --- a/drivers/crypto/cavium/cpt/cptpf_mbox.c +++ b/drivers/crypto/cavium/cpt/cptpf_mbox.c @@ -59,7 +59,7 @@ static void cpt_cfg_vq_priority(struct cpt_device *cpt, int vf, u32 pri) cpt_write_csr64(cpt->reg_base, CPTX_PF_QX_CTL(0, vf), pf_qx_ctl.u); } -static u8 cpt_bind_vq_to_grp(struct cpt_device *cpt, u8 q, u8 grp) +static int cpt_bind_vq_to_grp(struct cpt_device *cpt, u8 q, u8 grp) { struct microcode *mcode = cpt->mcode; union cptx_pf_qx_ctl pf_qx_ctl; @@ -90,7 +90,7 @@ static void cpt_handle_mbox_intr(struct cpt_device *cpt, int vf) { struct cpt_vf_info *vfx = &cpt->vfinfo[vf]; struct cpt_mbox mbx = {}; - u8 vftype; + int vftype; struct device *dev = &cpt->pdev->dev; /* * MBOX[0] contains msg |