diff options
| author | Yijing Wang <wangyijing@huawei.com> | 2014-05-30 05:01:03 +0200 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-05-30 17:34:27 +0200 |
| commit | c893d133eaccdda2516a3e71cd05a7dac2e14b00 (patch) | |
| tree | 2f296b5a88e4e794fb48d4c22c8108ce6f671bbc /drivers/edac | |
| parent | PCI: Fix return value from pci_user_{read,write}_config_*() (diff) | |
| download | linux-c893d133eaccdda2516a3e71cd05a7dac2e14b00.tar.xz linux-c893d133eaccdda2516a3e71cd05a7dac2e14b00.zip | |
PCI: Make pci_bus_add_device() void
pci_bus_add_device() always returns 0, so there's no point in returning
anything at all. Make it a void function and remove the tests of the
return value from the callers.
[bhelgaas: changelog, remove unused "err" from i82875p_setup_overfl_dev()]
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/edac')
| -rw-r--r-- | drivers/edac/i82875p_edac.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/edac/i82875p_edac.c b/drivers/edac/i82875p_edac.c index 8d0450b9b9af..4009077c8839 100644 --- a/drivers/edac/i82875p_edac.c +++ b/drivers/edac/i82875p_edac.c @@ -275,7 +275,6 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev, { struct pci_dev *dev; void __iomem *window; - int err; *ovrfl_pdev = NULL; *ovrfl_window = NULL; @@ -293,12 +292,7 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev, if (dev == NULL) return 1; - err = pci_bus_add_device(dev); - if (err) { - i82875p_printk(KERN_ERR, - "%s(): pci_bus_add_device() Failed\n", - __func__); - } + pci_bus_add_device(dev); pci_bus_assign_resources(dev->bus); } |