diff options
| author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2024-03-18 09:59:14 +0100 |
|---|---|---|
| committer | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2024-03-21 13:20:18 +0100 |
| commit | bfb1ad3c6aab2341ace13222ac0a78e5b4c239c8 (patch) | |
| tree | 80a5868309a63447c55ee3c414e0c957fdfa8765 /drivers/firewire | |
| parent | Revert "firewire: Kill unnecessary buf check in device_attribute.show" (diff) | |
| download | linux-bfb1ad3c6aab2341ace13222ac0a78e5b4c239c8.tar.xz linux-bfb1ad3c6aab2341ace13222ac0a78e5b4c239c8.zip | |
firewire: core: add memo about the caller of show functions for device attributes
In the case of firewire core function, the caller of show functions for
device attributes is not only sysfs user, but also device initialization.
This commit adds memo about it against the typical assumption that the
functions are just dedicated to sysfs user.
Link: https://lore.kernel.org/lkml/20240318091759.678326-1-o-takashi@sakamocchi.jp/
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Diffstat (limited to 'drivers/firewire')
| -rw-r--r-- | drivers/firewire/core-device.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c index f208a02d0ebf..e6cdb905eeac 100644 --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -322,6 +322,7 @@ static ssize_t show_immediate(struct device *dev, if (value < 0) return -ENOENT; + // Note that this function is also called by init_fw_attribute_group() with NULL pointer. return buf ? sysfs_emit(buf, "0x%06x\n", value) : 0; } @@ -357,6 +358,7 @@ static ssize_t show_text_leaf(struct device *dev, } } + // Note that this function is also called by init_fw_attribute_group() with NULL pointer. if (buf) { bufsize = PAGE_SIZE - 1; } else { |