summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-sifive.c
diff options
context:
space:
mode:
authorJiasheng Jiang <jiasheng@iscas.ac.cn>2023-06-06 05:11:59 +0200
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2023-06-13 16:22:16 +0200
commitc1bcb976d8feb107ff2c12caaf12ac5e70f44d5f (patch)
tree16c8f6036995d2bd78a6593704ba0693166434a3 /drivers/gpio/gpio-sifive.c
parentgpiolib: Fix GPIO chip IRQ initialization restriction (diff)
downloadlinux-c1bcb976d8feb107ff2c12caaf12ac5e70f44d5f.tar.xz
linux-c1bcb976d8feb107ff2c12caaf12ac5e70f44d5f.zip
gpio: sifive: add missing check for platform_get_irq
Add the missing check for platform_get_irq() and return error code if it fails. The returned error code will be dealed with in builtin_platform_driver(sifive_gpio_driver) and the driver will not be registered. Fixes: f52d6d8b43e5 ("gpio: sifive: To get gpio irq offset from device tree data") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-sifive.c')
-rw-r--r--drivers/gpio/gpio-sifive.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
index 98939cd4a71e..745e5f67254e 100644
--- a/drivers/gpio/gpio-sifive.c
+++ b/drivers/gpio/gpio-sifive.c
@@ -221,8 +221,12 @@ static int sifive_gpio_probe(struct platform_device *pdev)
return -ENODEV;
}
- for (i = 0; i < ngpio; i++)
- chip->irq_number[i] = platform_get_irq(pdev, i);
+ for (i = 0; i < ngpio; i++) {
+ ret = platform_get_irq(pdev, i);
+ if (ret < 0)
+ return ret;
+ chip->irq_number[i] = ret;
+ }
ret = bgpio_init(&chip->gc, dev, 4,
chip->base + SIFIVE_GPIO_INPUT_VAL,