summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpiolib.c
diff options
context:
space:
mode:
authorStephen Boyd <swboyd@chromium.org>2019-08-01 00:28:26 +0200
committerLinus Walleij <linus.walleij@linaro.org>2019-08-01 10:04:16 +0200
commit49281a222ac42724b94f6c874f43a284ec58d37e (patch)
tree93bd75d6c9031876e8e67b63f8dcf2dcbd17f62f /drivers/gpio/gpiolib.c
parentgpiolib-acpi: Move acpi_dev_add_driver_gpios() et al to consumer.h (diff)
downloadlinux-49281a222ac42724b94f6c874f43a284ec58d37e.tar.xz
linux-49281a222ac42724b94f6c874f43a284ec58d37e.zip
gpio: of: Fix hard-assigned valid_mask for OF case
The recent refactoring to break out OF code to its own file contained a bug letting the need_valid_mask be overridden by the need of the device tree range check, and if there were no ranges, but device tree was active and the reserved GPIO used in another way, things likely crash. Cc: Mark Brown <broonie@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Stephen Boyd <swboyd@chromium.org> Fixes: f626d6dfb709 ("gpio: of: Break out OF-only code") Reported-by: Mark Brown <broonie@kernel.org> Suggested-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpiolib.c')
-rw-r--r--drivers/gpio/gpiolib.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index f83870a18ae7..20f13129cdaa 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -363,8 +363,8 @@ static unsigned long *gpiochip_allocate_mask(struct gpio_chip *chip)
static int gpiochip_alloc_valid_mask(struct gpio_chip *gc)
{
- if (IS_ENABLED(CONFIG_OF_GPIO))
- gc->need_valid_mask = of_gpio_need_valid_mask(gc);
+ if (of_gpio_need_valid_mask(gc))
+ gc->need_valid_mask = true;
if (!gc->need_valid_mask)
return 0;