summaryrefslogtreecommitdiffstats
path: root/drivers/gpio
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2024-07-19 16:44:10 +0200
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2024-07-19 16:56:27 +0200
commit3ae08e47742eeebf2190900d31ddac53fdd13a5b (patch)
tree145822a2ee899ba208df9949d7c3fcaf41df50ea /drivers/gpio
parentMerge tag 'gpio-updates-for-v6.11-rc1' of git://git.kernel.org/pub/scm/linux/... (diff)
downloadlinux-3ae08e47742eeebf2190900d31ddac53fdd13a5b.tar.xz
linux-3ae08e47742eeebf2190900d31ddac53fdd13a5b.zip
gpio: virtuser: avoid non-constant format string
Using a string variable as an sprintf format is potentially dangerous, and gcc can warn about this: drivers/gpio/gpio-virtuser.c: In function 'gpio_virtuser_dbgfs_init_line_attrs': drivers/gpio/gpio-virtuser.c:808:9: error: format not a string literal and no format arguments [-Werror=format-security] 808 | sprintf(data->consumer, id); | ^~~~~~~ Change it to a simpler strscpy() instead to just copy it and check the destination buffer size. Fixes: 91581c4b3f29 ("gpio: virtuser: new virtual testing driver for the GPIO API") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20240719144422.2082394-1-arnd@kernel.org Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Diffstat (limited to 'drivers/gpio')
-rw-r--r--drivers/gpio/gpio-virtuser.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-virtuser.c b/drivers/gpio/gpio-virtuser.c
index 0e0d55da4f01..ccc47ea0b3e1 100644
--- a/drivers/gpio/gpio-virtuser.c
+++ b/drivers/gpio/gpio-virtuser.c
@@ -805,7 +805,7 @@ static int gpio_virtuser_dbgfs_init_line_attrs(struct device *dev,
return -ENOMEM;
data->ad.desc = desc;
- sprintf(data->consumer, id);
+ strscpy(data->consumer, id);
atomic_set(&data->irq, 0);
atomic_set(&data->irq_count, 0);