diff options
| author | Tom Rix <trix@redhat.com> | 2020-10-03 21:39:28 +0200 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2020-10-05 15:52:37 +0200 |
| commit | 4e19d51ca5b28a1d435a844c7b2a8e1b1b6fa237 (patch) | |
| tree | 814f4a73fe0a1f72619076cd2b76c91d2c95c910 /drivers/gpu/drm/gma500/cdv_intel_dp.c | |
| parent | drm/sched: Avoid infinite waits in the drm_sched_entity_destroy() path (diff) | |
| download | linux-4e19d51ca5b28a1d435a844c7b2a8e1b1b6fa237.tar.xz linux-4e19d51ca5b28a1d435a844c7b2a8e1b1b6fa237.zip | |
drm/gma500: fix double free of gma_connector
clang static analysis reports this problem:
cdv_intel_dp.c:2101:2: warning: Attempt to free released memory
kfree(gma_connector);
^~~~~~~~~~~~~~~~~~~~
In cdv_intel_dp_init() when the call to cdv_intel_edp_panel_vdd_off()
fails, the handler calls cdv_intel_dp_destroy(connector) which does
the first free of gma_connector. So adjust the goto label and skip
the second free.
Fixes: d112a8163f83 ("gma500/cdv: Add eDP support")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201003193928.18869-1-trix@redhat.com
Diffstat (limited to 'drivers/gpu/drm/gma500/cdv_intel_dp.c')
| -rw-r--r-- | drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 50016a754172..bfd9a15d63b1 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -2082,7 +2082,7 @@ cdv_intel_dp_init(struct drm_device *dev, struct psb_intel_mode_device *mode_dev DRM_INFO("failed to retrieve link info, disabling eDP\n"); drm_encoder_cleanup(encoder); cdv_intel_dp_destroy(connector); - goto err_priv; + goto err_connector; } else { DRM_DEBUG_KMS("DPCD: Rev=%x LN_Rate=%x LN_CNT=%x LN_DOWNSP=%x\n", intel_dp->dpcd[0], intel_dp->dpcd[1], |