diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-04-14 08:02:24 +0200 |
|---|---|---|
| committer | Jani Nikula <jani.nikula@intel.com> | 2021-04-26 10:54:27 +0200 |
| commit | 63b6c7be3e1f78a2d7e24ea3dde1333ffcc9b2a4 (patch) | |
| tree | 3633d5833ec696a66c9c657b67f78ffd2a2dbd82 /drivers/gpu | |
| parent | drm/i915/display/psr: Fix cppcheck warnings (diff) | |
| download | linux-63b6c7be3e1f78a2d7e24ea3dde1333ffcc9b2a4.tar.xz linux-63b6c7be3e1f78a2d7e24ea3dde1333ffcc9b2a4.zip | |
drm/i915: fix an error code in intel_overlay_do_put_image()
This code should propagate the error from intel_overlay_pin_fb()
but currently it returns success.
Fixes: 1b321026e213 ("drm/i915: Pass ww ctx to intel_pin_to_display_plane")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/YHaFcEzcnh/hk1/Q@mwanda
(cherry picked from commit 103b8cbac28ea2965f24ca52e6a92d76d3851b3c)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/i915/display/intel_overlay.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c index e477b6114a60..e5dadde422f7 100644 --- a/drivers/gpu/drm/i915/display/intel_overlay.c +++ b/drivers/gpu/drm/i915/display/intel_overlay.c @@ -803,8 +803,10 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay, atomic_inc(&dev_priv->gpu_error.pending_fb_pin); vma = intel_overlay_pin_fb(new_bo); - if (IS_ERR(vma)) + if (IS_ERR(vma)) { + ret = PTR_ERR(vma); goto out_pin_section; + } i915_gem_object_flush_frontbuffer(new_bo, ORIGIN_DIRTYFB); |