diff options
| author | Jean Delvare <jdelvare@suse.de> | 2019-08-06 10:21:23 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2019-09-03 21:47:17 +0200 |
| commit | dbf55205118e5d46cddf65a1d1e7ea16879a7c72 (patch) | |
| tree | 06227888034a746d3212610c5a298a8865fd594f /drivers/hwmon/Kconfig | |
| parent | hwmon: (npcm750-pwm-fan) Remove dev_err() usage after platform_get_irq() (diff) | |
| download | linux-dbf55205118e5d46cddf65a1d1e7ea16879a7c72.tar.xz linux-dbf55205118e5d46cddf65a1d1e7ea16879a7c72.zip | |
hwmon: w83795: Fan control option isn't that dangerous
I have been using SENSORS_W83795_FANCTRL for several years and never
had any problem. When the driver was added, I had not tested that
part of the driver yet so I wanted to be super cautious, but time has
shown that it works just fine.
In the long run I even believe that we should drop the option and
enable the feature unconditionally. It doesn't do anything until the
user explicitly starts twiddling with sysfs attributes anyway.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Link: https://lore.kernel.org/r/20190806102123.3118bcc5@endymion
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/Kconfig')
| -rw-r--r-- | drivers/hwmon/Kconfig | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 76cd0647ee2c..9de34e4f816c 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1824,17 +1824,12 @@ config SENSORS_W83795 will be called w83795. config SENSORS_W83795_FANCTRL - bool "Include automatic fan control support (DANGEROUS)" + bool "Include automatic fan control support" depends on SENSORS_W83795 help If you say yes here, support for automatic fan speed control will be included in the driver. - This part of the code wasn't carefully reviewed and tested yet, - so enabling this option is strongly discouraged on production - servers. Only developers and testers should enable it for the - time being. - Please also note that this option will create sysfs attribute files which may change in the future, so you shouldn't rely on them being stable. |