summaryrefslogtreecommitdiffstats
path: root/drivers/iio/magnetometer/ak8974.c
diff options
context:
space:
mode:
authorColin Ian King <colin.i.king@gmail.com>2022-10-20 15:57:09 +0200
committerKalle Valo <kvalo@kernel.org>2022-10-21 14:54:06 +0200
commit80e5acb6dd72b25a6e6527443b9e9c1c3a7bcef6 (patch)
tree1feec57093b02302797d8d4304b6ec39871db63a /drivers/iio/magnetometer/ak8974.c
parentbcma: gpio: Convert to immutable gpio irqchip (diff)
downloadlinux-80e5acb6dd72b25a6e6527443b9e9c1c3a7bcef6.tar.xz
linux-80e5acb6dd72b25a6e6527443b9e9c1c3a7bcef6.zip
wifi: rtl8xxxu: Fix reads of uninitialized variables hw_ctrl_s1, sw_ctrl_s1
Variables hw_ctrl_s1 and sw_ctrl_s1 are not being initialized and potentially can contain any garbage value. Currently there is an if statement that sets one or the other of these variables, followed by an if statement that checks if any of these variables have been set to a non-zero value. In the case where they may contain uninitialized non-zero values, the latter if statement may be taken as true when it was not expected to. Fix this by ensuring hw_ctrl_s1 and sw_ctrl_s1 are initialized. Cleans up clang warning: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:7: warning: variable 'hw_ctrl_s1' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (hw_ctrl) { ^~~~~~~ drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:440:7: note: uninitialized use occurs here if (hw_ctrl_s1 || sw_ctrl_s1) { ^~~~~~~~~~ drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:3: note: remove the 'if' if its condition is always true if (hw_ctrl) { ^~~~~~~~~~~~~ Fixes: c888183b21f3 ("wifi: rtl8xxxu: Support new chip RTL8188FU") Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20221020135709.1549086-1-colin.i.king@gmail.com
Diffstat (limited to 'drivers/iio/magnetometer/ak8974.c')
0 files changed, 0 insertions, 0 deletions