diff options
| author | William Breathitt Gray <william.gray@linaro.org> | 2023-04-06 16:40:13 +0200 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2023-04-10 13:26:33 +0200 |
| commit | a94abc74c5248d3c09bb18aa8437e85a6a31eadd (patch) | |
| tree | c16f8a68f47cac1bf37507d7076d11c0903fee9a /drivers/iio | |
| parent | iio: addac: stx104: Use define rather than hardcoded limit for write val (diff) | |
| download | linux-a94abc74c5248d3c09bb18aa8437e85a6a31eadd.tar.xz linux-a94abc74c5248d3c09bb18aa8437e85a6a31eadd.zip | |
iio: addac: stx104: Improve indentation in stx104_write_raw()
By bailing out early if chan->output is false for the IIO_CHAN_INFO_RAW,
indentation can be decreased by a tab and code readability improved.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
Link: https://lore.kernel.org/r/487d17da9e2612f3e6b2bd1c3def2fa1b955db9b.1680790580.git.william.gray@linaro.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
| -rw-r--r-- | drivers/iio/addac/stx104.c | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/drivers/iio/addac/stx104.c b/drivers/iio/addac/stx104.c index 0ed5f71b18cb..81020b710195 100644 --- a/drivers/iio/addac/stx104.c +++ b/drivers/iio/addac/stx104.c @@ -181,19 +181,19 @@ static int stx104_write_raw(struct iio_dev *indio_dev, return 0; case IIO_CHAN_INFO_RAW: - if (chan->output) { - if (val < 0 || val > U16_MAX) - return -EINVAL; + if (!chan->output) + return -EINVAL; - mutex_lock(&priv->lock); + if (val < 0 || val > U16_MAX) + return -EINVAL; - priv->chan_out_states[chan->channel] = val; - iowrite16(val, &priv->reg->dac[chan->channel]); + mutex_lock(&priv->lock); - mutex_unlock(&priv->lock); - return 0; - } - return -EINVAL; + priv->chan_out_states[chan->channel] = val; + iowrite16(val, &priv->reg->dac[chan->channel]); + + mutex_unlock(&priv->lock); + return 0; } return -EINVAL; |