diff options
| author | Ismail, Mustafa <mustafa.ismail@intel.com> | 2017-07-14 16:41:30 +0200 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2017-07-20 17:24:13 +0200 |
| commit | 5a7a88f1b488e4ee49eb3d5b82612d4d9ffdf2c3 (patch) | |
| tree | d6af1ba339e228d7b3fe40c1b7555f43795b3577 /drivers/infiniband | |
| parent | IB/cma: Fix reference count leak when no ipv4 addresses are set (diff) | |
| download | linux-5a7a88f1b488e4ee49eb3d5b82612d4d9ffdf2c3.tar.xz linux-5a7a88f1b488e4ee49eb3d5b82612d4d9ffdf2c3.zip | |
RDMA/uverbs: Fix the check for port number
The port number is only valid if IB_QP_PORT is set in the mask.
So only check port number if it is valid to prevent modify_qp from
failing due to an invalid port number.
Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
Cc: <stable@vger.kernel.org> # v2.6.14+
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
Tested-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/core/uverbs_cmd.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c index 71451eae42de..2c98533a0203 100644 --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -1933,7 +1933,8 @@ static int modify_qp(struct ib_uverbs_file *file, goto out; } - if (!rdma_is_port_valid(qp->device, cmd->base.port_num)) { + if ((cmd->base.attr_mask & IB_QP_PORT) && + !rdma_is_port_valid(qp->device, cmd->base.port_num)) { ret = -EINVAL; goto release_qp; } |