diff options
| author | Andrew Boyer <andrew.boyer@dell.com> | 2016-11-23 18:39:17 +0100 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2016-12-12 22:31:45 +0100 |
| commit | 6e9bb530ff8b07b3bbce79c937fc9dcb32da4eb9 (patch) | |
| tree | 09221ae857a177000f7dc0974d554bad3cdbfb57 /drivers/infiniband | |
| parent | IB/rxe: Remove unneeded cast in rxe_srq_from_attr() (diff) | |
| download | linux-6e9bb530ff8b07b3bbce79c937fc9dcb32da4eb9.tar.xz linux-6e9bb530ff8b07b3bbce79c937fc9dcb32da4eb9.zip | |
IB/rxe: Remove buffer used for printing IP address
Avoid smashing the stack when an ICRC error occurs on an IPv6 network.
Signed-off-by: Andrew Boyer <andrew.boyer@dell.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/sw/rxe/rxe_recv.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c index 46f062842a9a..252b4d637d45 100644 --- a/drivers/infiniband/sw/rxe/rxe_recv.c +++ b/drivers/infiniband/sw/rxe/rxe_recv.c @@ -391,16 +391,15 @@ int rxe_rcv(struct sk_buff *skb) payload_size(pkt)); calc_icrc = cpu_to_be32(~calc_icrc); if (unlikely(calc_icrc != pack_icrc)) { - char saddr[sizeof(struct in6_addr)]; - if (skb->protocol == htons(ETH_P_IPV6)) - sprintf(saddr, "%pI6", &ipv6_hdr(skb)->saddr); + pr_warn_ratelimited("bad ICRC from %pI6c\n", + &ipv6_hdr(skb)->saddr); else if (skb->protocol == htons(ETH_P_IP)) - sprintf(saddr, "%pI4", &ip_hdr(skb)->saddr); + pr_warn_ratelimited("bad ICRC from %pI4\n", + &ip_hdr(skb)->saddr); else - sprintf(saddr, "unknown"); + pr_warn_ratelimited("bad ICRC from unknown\n"); - pr_warn_ratelimited("bad ICRC from %s\n", saddr); goto drop; } |