diff options
| author | Yong Wu <yong.wu@mediatek.com> | 2021-01-07 13:29:06 +0100 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2021-01-27 13:32:27 +0100 |
| commit | 862c3715de8f3e5350489240c951d697f04bd8c9 (patch) | |
| tree | d6b5a2361e5fd76af8647003da0e9fcb18557855 /drivers/iommu/mtk_iommu.c | |
| parent | iommu/mediatek: Add iotlb_sync_map to sync whole the iova range (diff) | |
| download | linux-862c3715de8f3e5350489240c951d697f04bd8c9.tar.xz linux-862c3715de8f3e5350489240c951d697f04bd8c9.zip | |
iommu: Switch gather->end to the inclusive end
Currently gather->end is "unsigned long" which may be overflow in
arch32 in the corner case: 0xfff00000 + 0x100000(iova + size).
Although it doesn't affect the size(end - start), it affects the checking
"gather->end < end"
This patch changes this "end" to the real end address
(end = start + size - 1). Correspondingly, update the length to
"end - start + 1".
Fixes: a7d20dc19d9e ("iommu: Introduce struct iommu_iotlb_gather for batching TLB flushes")
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20210107122909.16317-5-yong.wu@mediatek.com
Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'drivers/iommu/mtk_iommu.c')
| -rw-r--r-- | drivers/iommu/mtk_iommu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index f579fc21971e..66a00a2cb445 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -443,7 +443,7 @@ static void mtk_iommu_iotlb_sync(struct iommu_domain *domain, struct iommu_iotlb_gather *gather) { struct mtk_iommu_data *data = mtk_iommu_get_m4u_data(); - size_t length = gather->end - gather->start; + size_t length = gather->end - gather->start + 1; if (gather->start == ULONG_MAX) return; |