diff options
| author | David Woodhouse <dwmw2@infradead.org> | 2006-09-29 10:58:37 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-29 18:18:03 +0200 |
| commit | 4efd587bf9f9a97608b1fcecc78a4a046c37e9b1 (patch) | |
| tree | ee626d2ce4af18c0296df3f257079b76f71ae76d /drivers/macintosh/via-pmu-backlight.c | |
| parent | [PATCH] remove generic__raw_read_trylock() (diff) | |
| download | linux-4efd587bf9f9a97608b1fcecc78a4a046c37e9b1.tar.xz linux-4efd587bf9f9a97608b1fcecc78a4a046c37e9b1.zip | |
[PATCH] Fix uninitialised spinlock in via-pmu-backlight code.
The uninitialised pmu_backlight_lock causes the current Fedora test kernel
(which has spinlock debugging enabled) to panic on suspend.
This is suboptimal, so I fixed it.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Michael Hanselmann <linux-kernel@hansmi.ch>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/macintosh/via-pmu-backlight.c')
| -rw-r--r-- | drivers/macintosh/via-pmu-backlight.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c index a82f313d9dc9..6c29fe727c0f 100644 --- a/drivers/macintosh/via-pmu-backlight.c +++ b/drivers/macintosh/via-pmu-backlight.c @@ -16,7 +16,7 @@ #define MAX_PMU_LEVEL 0xFF static struct backlight_properties pmu_backlight_data; -static spinlock_t pmu_backlight_lock; +static DEFINE_SPINLOCK(pmu_backlight_lock); static int sleeping; static u8 bl_curve[FB_BACKLIGHT_LEVELS]; |