diff options
| author | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-05-04 17:16:49 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-05-04 17:17:58 +0200 |
| commit | 89eaaf2d19a6cfff0a16014405c2a65b5257b8a1 (patch) | |
| tree | f6a9ad307add4a9b86268fdcf0839ef260b00509 /drivers/media/dvb-frontends | |
| parent | media: lgdt330x: add block error counts via DVBv5 (diff) | |
| download | linux-89eaaf2d19a6cfff0a16014405c2a65b5257b8a1.tar.xz linux-89eaaf2d19a6cfff0a16014405c2a65b5257b8a1.zip | |
media: lgdt330x: don't use an uninitialized state
If state is not initialized or is freed, we can't use it:
drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: potential null dereference 'state'. (kzalloc returns null)
drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: we previously assumed 'state' could be null (see line 878)
drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: dereferencing freed memory 'state'
Fixes: 23ba635d45f5 ("media: lgdt330x: convert it to the new I2C binding way")
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/dvb-frontends')
| -rw-r--r-- | drivers/media/dvb-frontends/lgdt330x.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/dvb-frontends/lgdt330x.c b/drivers/media/dvb-frontends/lgdt330x.c index 927fd68e05ec..f6731738b073 100644 --- a/drivers/media/dvb-frontends/lgdt330x.c +++ b/drivers/media/dvb-frontends/lgdt330x.c @@ -917,7 +917,8 @@ static int lgdt330x_probe(struct i2c_client *client, error: kfree(state); - dprintk(state, "ERROR\n"); + if (debug) + dev_printk(KERN_DEBUG, &client->dev, "Error loading lgdt330x driver\n"); return -ENODEV; } struct dvb_frontend *lgdt330x_attach(const struct lgdt330x_config *_config, |