diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-02-13 14:25:59 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-02-18 21:32:41 +0100 |
| commit | ffaec3b21abcce537be166bd023f55986a5b2002 (patch) | |
| tree | 0465c45b0287a37c1aac51e09cc1ddd4dc503818 /drivers/media/platform/exynos4-is/fimc-isp-video.c | |
| parent | media: v4l2-mem2mem: Correct return type for mem2mem buffer helpers (diff) | |
| download | linux-ffaec3b21abcce537be166bd023f55986a5b2002.tar.xz linux-ffaec3b21abcce537be166bd023f55986a5b2002.zip | |
media: exynos4-is: remove redundant check on type
The check to see if type is V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE is redundant
as this has been already checked at the start of the function and if
it's not that value then -ENOSYS is returned. Hence the sprintf can be
replaced by a simpler string copy.
Detected by CoverityScan, CID#1309450 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/platform/exynos4-is/fimc-isp-video.c')
| -rw-r--r-- | drivers/media/platform/exynos4-is/fimc-isp-video.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/media/platform/exynos4-is/fimc-isp-video.c b/drivers/media/platform/exynos4-is/fimc-isp-video.c index de6bd28f7e31..bb35a2017f21 100644 --- a/drivers/media/platform/exynos4-is/fimc-isp-video.c +++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c @@ -606,9 +606,7 @@ int fimc_isp_video_device_register(struct fimc_isp *isp, vdev = &iv->ve.vdev; memset(vdev, 0, sizeof(*vdev)); - snprintf(vdev->name, sizeof(vdev->name), "fimc-is-isp.%s", - type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE ? - "capture" : "output"); + strscpy(vdev->name, "fimc-is-isp.capture", sizeof(vdev->name)); vdev->queue = q; vdev->fops = &isp_video_fops; vdev->ioctl_ops = &isp_video_ioctl_ops; |