summaryrefslogtreecommitdiffstats
path: root/drivers/mmc/host/mmci_qcom_dml.c
diff options
context:
space:
mode:
authorUlf Hansson <ulf.hansson@linaro.org>2019-03-06 15:04:52 +0100
committerUlf Hansson <ulf.hansson@linaro.org>2019-04-15 11:55:54 +0200
commitc21aa7a804160f58e391c9fcb2aff16e7d30c80f (patch)
treea1aeac561c45693e541e932c0bdc98e8c72595fb /drivers/mmc/host/mmci_qcom_dml.c
parentmmc: mmci: Don't share un-implemented DMA functions (diff)
downloadlinux-c21aa7a804160f58e391c9fcb2aff16e7d30c80f.tar.xz
linux-c21aa7a804160f58e391c9fcb2aff16e7d30c80f.zip
mmc: mmci: Drop unnecessary clear of variant->qcom_dml flag
There's no point clearing the variant flag in case the qcom variant fails to setup DMA. This is because if mmci_dma_setup() fails, then the use_dma flag remains set to false, which leads to mmci using PIO mode and not DMA. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/mmc/host/mmci_qcom_dml.c')
-rw-r--r--drivers/mmc/host/mmci_qcom_dml.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
index 25d0a75533ea..b942d4aeeb77 100644
--- a/drivers/mmc/host/mmci_qcom_dml.c
+++ b/drivers/mmc/host/mmci_qcom_dml.c
@@ -133,7 +133,6 @@ static int qcom_dma_setup(struct mmci_host *host)
producer_id = of_get_dml_pipe_index(np, "rx");
if (producer_id < 0 || consumer_id < 0) {
- host->variant->qcom_dml = false;
mmci_dmae_release(host);
return -EINVAL;
}