diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-06-24 18:39:57 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-06-25 15:41:17 +0200 |
| commit | e4463e49e29f43eecec86e2e2b2e2ab4feb7d867 (patch) | |
| tree | 0fdf889b00a797ceefd7eb48cdc500c740ab3937 /drivers/most | |
| parent | staging: most: sound: remove overcautious argument checking (diff) | |
| download | linux-e4463e49e29f43eecec86e2e2b2e2ab4feb7d867.tar.xz linux-e4463e49e29f43eecec86e2e2b2e2ab4feb7d867.zip | |
staging: most: avoid null pointer dereference when iface is null
In the case where the pointer iface is null then the reporting of this
error will dereference iface when printing an error message causing which
is not ideal. Since the majority of callers to most_register_interface
report an error when -EINVAL is returned a simple fix is to just remove
the error message, I doubt it will be missed.
Addresses-Coverity: ("Dereference after null check")
Fixes: 57562a72414c ("Staging: most: add MOST driver's core module")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200624163957.11676-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/most')
| -rw-r--r-- | drivers/most/core.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/most/core.c b/drivers/most/core.c index f781c46cd4af..353ab277cbc6 100644 --- a/drivers/most/core.c +++ b/drivers/most/core.c @@ -1283,10 +1283,8 @@ int most_register_interface(struct most_interface *iface) struct most_channel *c; if (!iface || !iface->enqueue || !iface->configure || - !iface->poison_channel || (iface->num_channels > MAX_CHANNELS)) { - dev_err(iface->dev, "Bad interface or channel overflow\n"); + !iface->poison_channel || (iface->num_channels > MAX_CHANNELS)) return -EINVAL; - } id = ida_simple_get(&mdev_id, 0, 0, GFP_KERNEL); if (id < 0) { |