diff options
| author | Jon Mason <jdmason@kudzu.us> | 2011-06-27 09:44:43 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-06-28 06:40:45 +0200 |
| commit | e82760e7d6498d24d1a92f22767ba578c8980a6d (patch) | |
| tree | 04e38c4c44c6df3cc5f54cdfd170cd466f7b27a8 /drivers/net/bnx2.c | |
| parent | igb: remove unnecessary reads of PCI_CAP_ID_EXP (diff) | |
| download | linux-e82760e7d6498d24d1a92f22767ba578c8980a6d.tar.xz linux-e82760e7d6498d24d1a92f22767ba578c8980a6d.zip | |
bnx2: remove unnecessary read of PCI_CAP_ID_EXP
The PCIE capability offset is saved during PCI bus walking. It will
remove an unnecessary search in the PCI configuration space if this
value is referenced instead of reacquiring it. Also, pci_is_pcie is a
better way of determining if the device is PCIE or not (as it uses the
same saved PCIE capability offset).
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bnx2.c')
| -rw-r--r-- | drivers/net/bnx2.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 74580bb175f1..7915d1404572 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -7911,9 +7911,8 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) bp->chip_id = REG_RD(bp, BNX2_MISC_ID); if (CHIP_NUM(bp) == CHIP_NUM_5709) { - if (pci_find_capability(pdev, PCI_CAP_ID_EXP) == 0) { - dev_err(&pdev->dev, - "Cannot find PCIE capability, aborting\n"); + if (!pci_is_pcie(pdev)) { + dev_err(&pdev->dev, "Not PCIE, aborting\n"); rc = -EIO; goto err_out_unmap; } |