summaryrefslogtreecommitdiffstats
path: root/drivers/net/bonding/bond_main.c
diff options
context:
space:
mode:
authorZhengchao Shao <shaozhengchao@huawei.com>2023-11-23 02:55:15 +0100
committerDavid S. Miller <davem@davemloft.net>2023-11-24 16:21:32 +0100
commit486058f42a4728053ae69ebbf78e9731d8ce6f8b (patch)
tree6d092409000d2b9c6ad1008046c59e5eab0c9e0c /drivers/net/bonding/bond_main.c
parentnet/smc: remove unneeded atomic operations in smc_tx_sndbuf_nonempty (diff)
downloadlinux-486058f42a4728053ae69ebbf78e9731d8ce6f8b.tar.xz
linux-486058f42a4728053ae69ebbf78e9731d8ce6f8b.zip
bonding: remove print in bond_verify_device_path
As suggested by Paolo in link[1], if the memory allocation fails, the mm layer will emit a lot warning comprising the backtrace, so remove the print. [1] https://lore.kernel.org/all/20231118081653.1481260-1-shaozhengchao@huawei.com/ Suggested-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> Reviewed-by: Hangbin Liu <liuhangbin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_main.c')
-rw-r--r--drivers/net/bonding/bond_main.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index d987432cee3b..4e0600c7b050 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2973,11 +2973,8 @@ struct bond_vlan_tag *bond_verify_device_path(struct net_device *start_dev,
if (start_dev == end_dev) {
tags = kcalloc(level + 1, sizeof(*tags), GFP_ATOMIC);
- if (!tags) {
- net_err_ratelimited("%s: %s: Failed to allocate tags\n",
- __func__, start_dev->name);
+ if (!tags)
return ERR_PTR(-ENOMEM);
- }
tags[level].vlan_proto = BOND_VLAN_PROTO_NONE;
return tags;
}