diff options
| author | Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> | 2022-03-08 07:43:09 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-03-09 13:14:30 +0100 |
| commit | 2a760554dcba450d3ad61b32375b50ed6d59a87c (patch) | |
| tree | 9b9017bb86def4209cda900fa1dcce892ba04885 /drivers/net/ethernet/8390/mcf8390.c | |
| parent | net: ethernet: ti: cpts: Handle error for clk_enable (diff) | |
| download | linux-2a760554dcba450d3ad61b32375b50ed6d59a87c.tar.xz linux-2a760554dcba450d3ad61b32375b50ed6d59a87c.zip | |
net:mcf8390: Use platform_get_irq() to get the interrupt
It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ)
for requesting IRQ's resources any more, as they can be not ready yet in
case of DT-booting.
platform_get_irq() instead is a recommended way for getting IRQ even if
it was not retrieved earlier.
It also makes code simpler because we're getting "int" value right away
and no conversion from resource to int is required.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/8390/mcf8390.c')
| -rw-r--r-- | drivers/net/ethernet/8390/mcf8390.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/net/ethernet/8390/mcf8390.c b/drivers/net/ethernet/8390/mcf8390.c index e320cccba61a..90cd7bdf06f5 100644 --- a/drivers/net/ethernet/8390/mcf8390.c +++ b/drivers/net/ethernet/8390/mcf8390.c @@ -405,12 +405,12 @@ static int mcf8390_init(struct net_device *dev) static int mcf8390_probe(struct platform_device *pdev) { struct net_device *dev; - struct resource *mem, *irq; + struct resource *mem; resource_size_t msize; - int ret; + int ret, irq; - irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); - if (irq == NULL) { + irq = platform_get_irq(pdev, 0); + if (irq < 0) { dev_err(&pdev->dev, "no IRQ specified?\n"); return -ENXIO; } @@ -433,7 +433,7 @@ static int mcf8390_probe(struct platform_device *pdev) SET_NETDEV_DEV(dev, &pdev->dev); platform_set_drvdata(pdev, dev); - dev->irq = irq->start; + dev->irq = irq; dev->base_addr = mem->start; ret = mcf8390_init(dev); |