diff options
| author | Toke Høiland-Jørgensen <toke@redhat.com> | 2021-06-24 18:05:57 +0200 |
|---|---|---|
| committer | Daniel Borkmann <daniel@iogearbox.net> | 2021-06-24 19:43:28 +0200 |
| commit | 0939e0537896e421e391fa4b1a0b052907808e0d (patch) | |
| tree | 94ab414ba688756b8a15d053190635bafaef6b30 /drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | |
| parent | bpf, sched: Remove unneeded rcu_read_lock() around BPF program invocation (diff) | |
| download | linux-0939e0537896e421e391fa4b1a0b052907808e0d.tar.xz linux-0939e0537896e421e391fa4b1a0b052907808e0d.zip | |
ena: Remove rcu_read_lock() around XDP program invocation
The ena driver has rcu_read_lock()/rcu_read_unlock() pairs around XDP
program invocations. However, the actual lifetime of the objects referred
by the XDP program invocation is longer, all the way through to the call to
xdp_do_flush(), making the scope of the rcu_read_lock() too small. This
turns out to be harmless because it all happens in a single NAPI poll
cycle (and thus under local_bh_disable()), but it makes the rcu_read_lock()
misleading.
Rather than extend the scope of the rcu_read_lock(), just get rid of it
entirely. With the addition of RCU annotations to the XDP_REDIRECT map
types that take bh execution into account, lockdep even understands this to
be safe, so there's really no reason to keep it around.
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Saeed Bishara <saeedb@amazon.com>
Cc: Guy Tzalik <gtzalik@amazon.com>
Link: https://lore.kernel.org/bpf/20210624160609.292325-8-toke@redhat.com
Diffstat (limited to 'drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c')
0 files changed, 0 insertions, 0 deletions