diff options
| author | Martin Roth <martin.roth@motorolasolutions.com> | 2015-12-15 03:17:53 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-12-17 00:32:35 +0100 |
| commit | 79aa05a24f01bcb0cfbac3deea4f12d9b4f64ba9 (patch) | |
| tree | 1fc77f55d999d4021c6783b6e65e935defef3de7 /drivers/net/ethernet/freescale | |
| parent | gianfar: Don't enable RX Filer if not supported (diff) | |
| download | linux-79aa05a24f01bcb0cfbac3deea4f12d9b4f64ba9.tar.xz linux-79aa05a24f01bcb0cfbac3deea4f12d9b4f64ba9.zip | |
82xx: FCC: Fixing a bug causing to FCC port lock-up
The patch fixes FCC port lock-up, which occurs as a result of a bug
during underrun/collision handling. Within the tx_startup() function
in mac-fcc.c, the address of last BD is not calculated correctly.
As a result of wrong calculation of the last BD address, the next
transmitted BD may be set to an area out of the transmit BD ring.
This actually causes to port lock-up and it is not recoverable.
Signed-off-by: Martin Roth <martin.roth@motorolasolutions.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale')
| -rw-r--r-- | drivers/net/ethernet/freescale/fs_enet/mac-fcc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c b/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c index 08f5b911d96b..52e0091b4fb2 100644 --- a/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c +++ b/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c @@ -552,7 +552,7 @@ static void tx_restart(struct net_device *dev) cbd_t __iomem *prev_bd; cbd_t __iomem *last_tx_bd; - last_tx_bd = fep->tx_bd_base + (fpi->tx_ring * sizeof(cbd_t)); + last_tx_bd = fep->tx_bd_base + ((fpi->tx_ring - 1) * sizeof(cbd_t)); /* get the current bd held in TBPTR and scan back from this point */ recheck_bd = curr_tbptr = (cbd_t __iomem *) |