diff options
| author | Lin Ma <linma@zju.edu.cn> | 2024-04-10 05:48:46 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-04-13 03:52:35 +0200 |
| commit | a799de0e598583c18c03ce438648783b92c653de (patch) | |
| tree | bba28630e2e7f439d7bc0b0f3e4431ba4b08efc8 /drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | |
| parent | Merge branch 'ptp-convert-to-platform-remove-callback-returning-void' (diff) | |
| download | linux-a799de0e598583c18c03ce438648783b92c653de.tar.xz linux-a799de0e598583c18c03ce438648783b92c653de.zip | |
net: nfc: remove inappropriate attrs check
Revert "NFC: fix attrs checks in netlink interface"
This reverts commit 18917d51472fe3b126a3a8f756c6b18085eb8130.
Our checks found weird attrs present check in function
nfc_genl_dep_link_down() and nfc_genl_llc_get_params(), which are
introduced by commit 18917d51472f ("NFC: fix attrs checks in netlink
interface").
According to its message, it should add checks for functions
nfc_genl_deactivate_target() and nfc_genl_fw_download(). However, it
didn't do that. In fact, the expected checks are added by
(1) commit 385097a36757 ("nfc: Ensure presence of required attributes in
the deactivate_target handler") and
(2) commit 280e3ebdafb8 ("nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME
attribute in nfc_genl_fw_download()"). Perhaps something went wrong.
Anyway, the attr NFC_ATTR_TARGET_INDEX is never accessed in callback
nfc_genl_dep_link_down() and same for NFC_ATTR_FIRMWARE_NAME and
nfc_genl_llc_get_params(). Thus, remove those checks.
Signed-off-by: Lin Ma <linma@zju.edu.cn>
Link: https://lore.kernel.org/r/20240410034846.167421-1-linma@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c')
0 files changed, 0 insertions, 0 deletions