diff options
| author | Zhang Changzhong <zhangchangzhong@huawei.com> | 2020-11-12 12:34:39 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2020-11-13 02:58:37 +0100 |
| commit | baee1991fad928d6c8dd5be3197ecb413c420c97 (patch) | |
| tree | adfd9cb935fb5c860d3b60ea6bba3e0f8997feac /drivers/net/ethernet/mediatek/mtk_star_emac.c | |
| parent | net: ethernet: mtk-star-emac: return ok when xmit drops (diff) | |
| download | linux-baee1991fad928d6c8dd5be3197ecb413c420c97.tar.xz linux-baee1991fad928d6c8dd5be3197ecb413c420c97.zip | |
net: ethernet: mtk-star-emac: fix error return code in mtk_star_enable()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/1605180879-2573-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/mediatek/mtk_star_emac.c')
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_star_emac.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index e56a26f797f2..a8641a407c06 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -966,6 +966,7 @@ static int mtk_star_enable(struct net_device *ndev) mtk_star_adjust_link, 0, priv->phy_intf); if (!priv->phydev) { netdev_err(ndev, "failed to connect to PHY\n"); + ret = -ENODEV; goto err_free_irq; } |