diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-06-20 15:43:28 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-06-21 23:40:08 +0200 |
| commit | b90788459cd6d140171b046f0b37fad341ade0a3 (patch) | |
| tree | 1206a5861b34b6c2bea44fdc18c2840a46c95d12 /drivers/net/ethernet/microsoft | |
| parent | Merge branch 'nnicstar-fixes' (diff) | |
| download | linux-b90788459cd6d140171b046f0b37fad341ade0a3.tar.xz linux-b90788459cd6d140171b046f0b37fad341ade0a3.zip | |
net: mana: Fix a memory leak in an error handling path in 'mana_create_txq()'
If this test fails we must free some resources as in all the other error
handling paths of this function.
Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/microsoft')
| -rw-r--r-- | drivers/net/ethernet/microsoft/mana/mana_en.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index 04d067243457..1ed25e48f616 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -1230,8 +1230,10 @@ static int mana_create_txq(struct mana_port_context *apc, cq->gdma_id = cq->gdma_cq->id; - if (WARN_ON(cq->gdma_id >= gc->max_num_cqs)) - return -EINVAL; + if (WARN_ON(cq->gdma_id >= gc->max_num_cqs)) { + err = -EINVAL; + goto out; + } gc->cq_table[cq->gdma_id] = cq->gdma_cq; |