diff options
author | Finn Thain <fthain@telegraphics.com.au> | 2020-02-15 22:03:32 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-02-17 04:48:22 +0100 |
commit | d35bf9bc7d72a5e3055c808e5d5530a81a0c9a38 (patch) | |
tree | 01d3aa58104374b18b0c09d5f6ff2b0d603286bf /drivers/net/ethernet/natsemi | |
parent | net/sonic: Remove redundant next_tx variable (diff) | |
download | linux-d35bf9bc7d72a5e3055c808e5d5530a81a0c9a38.tar.xz linux-d35bf9bc7d72a5e3055c808e5d5530a81a0c9a38.zip |
net/sonic: Remove redundant netif_start_queue() call
The transmit queue must be running already otherwise sonic_send_packet()
would not have been called. If the queue was stopped by the interrupt
handler, the interrupt handler will restart it again.
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/natsemi')
-rw-r--r-- | drivers/net/ethernet/natsemi/sonic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c index 9ecdd67e1410..1d6de6706875 100644 --- a/drivers/net/ethernet/natsemi/sonic.c +++ b/drivers/net/ethernet/natsemi/sonic.c @@ -327,7 +327,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev) netif_dbg(lp, tx_queued, dev, "%s: stopping queue\n", __func__); netif_stop_queue(dev); /* after this packet, wait for ISR to free up some TDAs */ - } else netif_start_queue(dev); + } netif_dbg(lp, tx_queued, dev, "%s: issuing Tx command\n", __func__); |