diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-04-22 11:36:41 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-04-23 21:34:43 +0200 |
| commit | c391eb8366ae052d571bb2841f1ccb4d39f3ceb8 (patch) | |
| tree | bcb1781de82c335fe3948a179f026614adfd2772 /drivers/net/ethernet/nxp | |
| parent | net: phy: marvell10g: limit soft reset to 88x3310 (diff) | |
| download | linux-c391eb8366ae052d571bb2841f1ccb4d39f3ceb8.tar.xz linux-c391eb8366ae052d571bb2841f1ccb4d39f3ceb8.zip | |
mlxsw: Fix some IS_ERR() vs NULL bugs
The mlxsw_sp_acl_rulei_create() function is supposed to return an error
pointer from mlxsw_afa_block_create(). The problem is that these
functions both return NULL instead of error pointers. Half the callers
expect NULL and half expect error pointers so it could lead to a NULL
dereference on failure.
This patch changes both of them to return error pointers and changes all
the callers which checked for NULL to check for IS_ERR() instead.
Fixes: 4cda7d8d7098 ("mlxsw: core: Introduce flexible actions support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/nxp')
0 files changed, 0 insertions, 0 deletions