diff options
author | Arnd Bergmann <arnd@arndb.de> | 2019-03-18 17:35:11 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-03-19 21:26:03 +0100 |
commit | 7442c483b963dbee7d1b655cbad99c727c047828 (patch) | |
tree | 572d1258bb8c9eabfbe43ef99d6c5483e7bc6659 /drivers/net/ethernet/stmicro/stmmac/ring_mode.c | |
parent | Merge tag 'wireless-drivers-for-davem-2019-03-19' of git://git.kernel.org/pub... (diff) | |
download | linux-7442c483b963dbee7d1b655cbad99c727c047828.tar.xz linux-7442c483b963dbee7d1b655cbad99c727c047828.zip |
mlxsw: core: mlxsw: core: avoid -Wint-in-bool-context warning
A recently added function in mlxsw triggers a harmless compiler warning:
In file included from drivers/net/ethernet/mellanox/mlxsw/core.h:17,
from drivers/net/ethernet/mellanox/mlxsw/core_env.c:7:
drivers/net/ethernet/mellanox/mlxsw/core_env.c: In function 'mlxsw_env_module_temp_thresholds_get':
drivers/net/ethernet/mellanox/mlxsw/reg.h:8015:45: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]
#define MLXSW_REG_MTMP_TEMP_TO_MC(val) (val * 125)
~~~~~^~~~~~
drivers/net/ethernet/mellanox/mlxsw/core_env.c:116:8: note: in expansion of macro 'MLXSW_REG_MTMP_TEMP_TO_MC'
if (!MLXSW_REG_MTMP_TEMP_TO_MC(module_temp)) {
^~~~~~~~~~~~~~~~~~~~~~~~~
The warning is normally disabled, but it would be nice to enable
it to find real bugs, and there are no other known instances at
the moment.
Replace the negation with a zero-comparison, which also matches
the comment above it.
Fixes: d93c19a1d95c ("mlxsw: core: Add API for QSFP module temperature thresholds reading")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/stmicro/stmmac/ring_mode.c')
0 files changed, 0 insertions, 0 deletions