diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2020-01-23 15:27:29 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-01-25 10:15:49 +0100 |
| commit | 53c677009581ac5dbe46c4cf667e408ebfe3049a (patch) | |
| tree | 77a79e0ac8ec31c3a1b07ea59cafb6702856bc63 /drivers/net/fddi | |
| parent | net: atm: use %*ph to print small buffer (diff) | |
| download | linux-53c677009581ac5dbe46c4cf667e408ebfe3049a.tar.xz linux-53c677009581ac5dbe46c4cf667e408ebfe3049a.zip | |
net: fddi: skfp: Use print_hex_dump() helper
Use the print_hex_dump() helper, instead of open-coding the same operations.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/fddi')
| -rw-r--r-- | drivers/net/fddi/skfp/skfddi.c | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/drivers/net/fddi/skfp/skfddi.c b/drivers/net/fddi/skfp/skfddi.c index 15754451cb87..69c29a2ef95d 100644 --- a/drivers/net/fddi/skfp/skfddi.c +++ b/drivers/net/fddi/skfp/skfddi.c @@ -1520,22 +1520,8 @@ void mac_drv_tx_complete(struct s_smc *smc, volatile struct s_smt_fp_txd *txd) #ifdef DUMPPACKETS void dump_data(unsigned char *Data, int length) { - int i, j; - unsigned char s[255], sh[10]; - if (length > 64) { - length = 64; - } printk(KERN_INFO "---Packet start---\n"); - for (i = 0, j = 0; i < length / 8; i++, j += 8) - printk(KERN_INFO "%02x %02x %02x %02x %02x %02x %02x %02x\n", - Data[j + 0], Data[j + 1], Data[j + 2], Data[j + 3], - Data[j + 4], Data[j + 5], Data[j + 6], Data[j + 7]); - strcpy(s, ""); - for (i = 0; i < length % 8; i++) { - sprintf(sh, "%02x ", Data[j + i]); - strcat(s, sh); - } - printk(KERN_INFO "%s\n", s); + print_hex_dump(KERN_INFO, "", DUMP_PREFIX_NONE, 16, 1, Data, min_t(size_t, length, 64), false); printk(KERN_INFO "------------------\n"); } // dump_data #else |