diff options
| author | Alex Elder <elder@linaro.org> | 2021-04-09 20:07:20 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-04-10 05:57:25 +0200 |
| commit | 74858b63c47cfbacafb26ea9701b26ffa18acd4a (patch) | |
| tree | ad6e1df2e4abbc6b7fc70fbe35c4cb8d4c41646f /drivers/net/ipa/ipa_resource.c | |
| parent | net: ipa: ipa_stop() does not return an error (diff) | |
| download | linux-74858b63c47cfbacafb26ea9701b26ffa18acd4a.tar.xz linux-74858b63c47cfbacafb26ea9701b26ffa18acd4a.zip | |
net: ipa: get rid of empty IPA functions
There are place holder functions in the IPA code that do nothing.
For the most part these are inverse functions, for example, once the
routing or filter tables are set up there is no need to perform any
matching teardown activity at shutdown, or in the case of an error.
These can be safely removed, resulting in some code simplification.
Add comments in these spots making it explicit that there is no
inverse.
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ipa/ipa_resource.c')
| -rw-r--r-- | drivers/net/ipa/ipa_resource.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c index 85f922d6f222..3b2dc216d3a6 100644 --- a/drivers/net/ipa/ipa_resource.c +++ b/drivers/net/ipa/ipa_resource.c @@ -158,7 +158,7 @@ static void ipa_resource_config_dst(struct ipa *ipa, u32 resource_type, ipa_resource_config_common(ipa, offset, &resource->limits[6], ylimits); } -/* Configure resources */ +/* Configure resources; there is no ipa_resource_deconfig() */ int ipa_resource_config(struct ipa *ipa, const struct ipa_resource_data *data) { u32 i; @@ -174,9 +174,3 @@ int ipa_resource_config(struct ipa *ipa, const struct ipa_resource_data *data) return 0; } - -/* Inverse of ipa_resource_config() */ -void ipa_resource_deconfig(struct ipa *ipa) -{ - /* Nothing to do */ -} |