summaryrefslogtreecommitdiffstats
path: root/drivers/net/phy/bcm54140.c
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2020-04-23 16:10:16 +0200
committerDavid S. Miller <davem@davemloft.net>2020-04-24 00:56:47 +0200
commitefcd549da9d7e8194b4d2d2f35eff8ce7b4da684 (patch)
tree1b3f110abe02e227842b7b2c1d2e486bb344e84e /drivers/net/phy/bcm54140.c
parentqed: Make ll2_cbs static (diff)
downloadlinux-efcd549da9d7e8194b4d2d2f35eff8ce7b4da684.tar.xz
linux-efcd549da9d7e8194b4d2d2f35eff8ce7b4da684.zip
net: phy: bcm54140: fix less than zero comparison on an unsigned
Currently the unsigned variable tmp is being checked for an negative error return from the call to bcm_phy_read_rdb and this can never be true since tmp is unsigned. Fix this by making tmp a plain int. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 4406d36dfdf1 ("net: phy: bcm54140: add hwmon support") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Michael Walle <michael@walle.cc> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/bcm54140.c')
-rw-r--r--drivers/net/phy/bcm54140.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/phy/bcm54140.c b/drivers/net/phy/bcm54140.c
index aa854477e06a..7341f0126cc4 100644
--- a/drivers/net/phy/bcm54140.c
+++ b/drivers/net/phy/bcm54140.c
@@ -191,7 +191,8 @@ out:
static int bcm54140_hwmon_read_temp(struct device *dev, u32 attr, long *val)
{
struct phy_device *phydev = dev_get_drvdata(dev);
- u16 reg, tmp;
+ u16 reg;
+ int tmp;
switch (attr) {
case hwmon_temp_input:
@@ -224,7 +225,8 @@ static int bcm54140_hwmon_read_in(struct device *dev, u32 attr,
int channel, long *val)
{
struct phy_device *phydev = dev_get_drvdata(dev);
- u16 bit, reg, tmp;
+ u16 bit, reg;
+ int tmp;
switch (attr) {
case hwmon_in_input: