diff options
| author | Jinjie Ruan <ruanjinjie@huawei.com> | 2024-08-30 05:13:20 +0200 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2024-09-03 12:54:43 +0200 |
| commit | 1dce520abd461efcaf4a5a942d8eb833eef52d0b (patch) | |
| tree | 6497eb6a85955f682a78083b515996b68fec24e7 /drivers/net/phy | |
| parent | net: dsa: realtek: Use for_each_child_of_node_scoped() (diff) | |
| download | linux-1dce520abd461efcaf4a5a942d8eb833eef52d0b.tar.xz linux-1dce520abd461efcaf4a5a942d8eb833eef52d0b.zip | |
net: phy: Use for_each_available_child_of_node_scoped()
Avoid need to manually handle of_node_put() by using
for_each_available_child_of_node_scoped(), which can simplfy code.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/phy')
| -rw-r--r-- | drivers/net/phy/phy_device.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 8f5314c1fecc..7c4a09455493 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -3407,7 +3407,7 @@ static int of_phy_led(struct phy_device *phydev, static int of_phy_leds(struct phy_device *phydev) { struct device_node *node = phydev->mdio.dev.of_node; - struct device_node *leds, *led; + struct device_node *leds; int err; if (!IS_ENABLED(CONFIG_OF_MDIO)) @@ -3420,10 +3420,9 @@ static int of_phy_leds(struct phy_device *phydev) if (!leds) return 0; - for_each_available_child_of_node(leds, led) { + for_each_available_child_of_node_scoped(leds, led) { err = of_phy_led(phydev, led); if (err) { - of_node_put(led); phy_leds_unregister(phydev); return err; } |