diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-08-06 17:04:35 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-08-07 00:40:37 +0200 |
| commit | 06669e6880be7422bb9926f71be39c4924b92fea (patch) | |
| tree | 2e1609e8910e8d3478874791848d49c42f6bf39e /drivers/net/vrf.c | |
| parent | net: dsa: mt7530: drop untagged frames on VLAN-aware ports without PVID (diff) | |
| download | linux-06669e6880be7422bb9926f71be39c4924b92fea.tar.xz linux-06669e6880be7422bb9926f71be39c4924b92fea.zip | |
vrf: fix NULL dereference in vrf_finish_output()
The "skb" pointer is NULL on this error path so we can't dereference it.
Use "dev" instead.
Fixes: 14ee70ca89e6 ("vrf: use skb_expand_head in vrf_finish_output")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210806150435.GB15586@kili
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/vrf.c')
| -rw-r--r-- | drivers/net/vrf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 726adf07ef31..662e26117353 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -864,7 +864,7 @@ static int vrf_finish_output(struct net *net, struct sock *sk, struct sk_buff *s if (unlikely(skb_headroom(skb) < hh_len && dev->header_ops)) { skb = skb_expand_head(skb, hh_len); if (!skb) { - skb->dev->stats.tx_errors++; + dev->stats.tx_errors++; return -ENOMEM; } } |