summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorBen Greear <greearb@candelatech.com>2022-01-08 20:08:14 +0100
committerFelix Fietkau <nbd@nbd.name>2022-02-03 13:57:59 +0100
commit827e7799c61b978fbc2cc9dac66cb62401b2b3f0 (patch)
tree5651c91ece06755cfc70be66c2e1e846721e08be /drivers/net
parentmt76: mt7921e: fix possible probe failure after reboot (diff)
downloadlinux-827e7799c61b978fbc2cc9dac66cb62401b2b3f0.tar.xz
linux-827e7799c61b978fbc2cc9dac66cb62401b2b3f0.zip
mt76: mt7921: fix crash when startup fails.
If the nic fails to start, it is possible that the reset_work has already been scheduled. Ensure the work item is canceled so we do not have use-after-free crash in case cleanup is called before the work item is executed. This fixes crash on my x86_64 apu2 when mt7921k radio fails to work. Radio still fails, but OS does not crash. Signed-off-by: Ben Greear <greearb@candelatech.com> Signed-off-by: Felix Fietkau <nbd@nbd.name>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wireless/mediatek/mt76/mt7921/main.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
index e3f15ca11a80..0e101f14e41f 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
@@ -273,6 +273,7 @@ static void mt7921_stop(struct ieee80211_hw *hw)
cancel_delayed_work_sync(&dev->pm.ps_work);
cancel_work_sync(&dev->pm.wake_work);
+ cancel_work_sync(&dev->reset_work);
mt76_connac_free_pending_tx_skbs(&dev->pm, NULL);
mt7921_mutex_acquire(dev);