summaryrefslogtreecommitdiffstats
path: root/drivers/ntb/hw/amd
diff options
context:
space:
mode:
authorYuan Can <yuancan@huawei.com>2022-11-05 10:43:01 +0100
committerJon Mason <jdmason@kudzu.us>2023-07-08 16:51:55 +0200
commitc012968259b451dc4db407f2310fe131eaefd800 (patch)
tree8ea78789c6ee47d1a27e7997904c916fd60f3caa /drivers/ntb/hw/amd
parentLinux 6.4 (diff)
downloadlinux-c012968259b451dc4db407f2310fe131eaefd800.tar.xz
linux-c012968259b451dc4db407f2310fe131eaefd800.zip
ntb: idt: Fix error handling in idt_pci_driver_init()
A problem about ntb_hw_idt create debugfs failed is triggered with the following log given: [ 1236.637636] IDT PCI-E Non-Transparent Bridge Driver 2.0 [ 1236.639292] debugfs: Directory 'ntb_hw_idt' with parent '/' already present! The reason is that idt_pci_driver_init() returns pci_register_driver() directly without checking its return value, if pci_register_driver() failed, it returns without destroy the newly created debugfs, resulting the debugfs of ntb_hw_idt can never be created later. idt_pci_driver_init() debugfs_create_dir() # create debugfs directory pci_register_driver() driver_register() bus_add_driver() priv = kzalloc(...) # OOM happened # return without destroy debugfs directory Fix by removing debugfs when pci_register_driver() returns error. Fixes: bf2a952d31d2 ("NTB: Add IDT 89HPESxNTx PCIe-switches support") Signed-off-by: Yuan Can <yuancan@huawei.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers/ntb/hw/amd')
0 files changed, 0 insertions, 0 deletions