diff options
| author | Hannes Reinecke <hare@kernel.org> | 2024-09-14 14:01:22 +0200 |
|---|---|---|
| committer | Keith Busch <kbusch@kernel.org> | 2024-09-25 08:30:28 +0200 |
| commit | 63bcf9014e95a7d279d10d8e2caa5d88db2b1855 (patch) | |
| tree | ad3120c68487ff0975e7dacb25717a26616b56f9 /drivers/nvme | |
| parent | lib/sbitmap: define swap_lock as raw_spinlock_t (diff) | |
| download | linux-63bcf9014e95a7d279d10d8e2caa5d88db2b1855.tar.xz linux-63bcf9014e95a7d279d10d8e2caa5d88db2b1855.zip | |
nvme-multipath: system fails to create generic nvme device
NVME_NSHEAD_DISK_LIVE is a flag for struct nvme_ns_head, not nvme_ns.
The current code has a typo causing NVME_NSHEAD_DISK_LIVE never to
be cleared once device_add_disk_fails, causing the system never to
create the 'generic' character device. Even several rescan attempts
will change the situation and the system has to be rebooted to fix
the issue.
Fixes: 11384580e332 ("nvme-multipath: add error handling support for add_disk()")
Signed-off-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/multipath.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 518e22dd4f9b..6d97058cde7a 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -648,7 +648,7 @@ static void nvme_mpath_set_live(struct nvme_ns *ns) rc = device_add_disk(&head->subsys->dev, head->disk, nvme_ns_attr_groups); if (rc) { - clear_bit(NVME_NSHEAD_DISK_LIVE, &ns->flags); + clear_bit(NVME_NSHEAD_DISK_LIVE, &head->flags); return; } nvme_add_ns_head_cdev(head); |